On Wed, Apr 24, 2019 at 04:41:01PM +0800, Kewen.Lin wrote:
> gcc/ChangeLog
Not a review, just ChangeLog nits.
> 2019-04-24 Kewen Lin <li...@gcc.gnu.org>
>
> PR middle-end/80791
> * target.def (predict_doloop_p): New.
> * targhooks.h (default_predict_doloop_p): New.
> * targhooks.c (default_predict_doloop_p): Likewise.
> * doc/tm.texi.in (TARGET_PREDICT_DOLOOP_P): New.
> * doc/tm.texi: Regenerate.
> * config/rs6000/rs6000.c (invalid_insn_for_doloop_p): New.
> (costly_iter_for_doloop_p): New.
> (rs6000_predict_doloop_p): New.
There should be no leading spaces after the tab on the lines that don't contain
a filename, so:
* config/rs6000/rs6000.c (invalid_insn_for_doloop_p): New.
(costly_iter_for_doloop_p): New.
(rs6000_predict_doloop_p): New.
instead (and instead of saying just New. usually we write what kind of
new thing it is, so New function., New declaration. (or Declare.), New
macro. (or Define.), New method. etc.
> * gcc/expr.c (produce_memory_decl_rtl): New.
The gcc/ prefixes don't belong into gcc/ChangeLog, the filenames are always
relative to the ChangeLog file referencing those.
Jakub
