On Apr 20 2019, Émeric Dupont <emeric.dup...@zii.aero> wrote: > The following patch fixes this issue by using the [Make $(sort list)][1] > function instead to remove duplicates from the list of headers. There is > no functional change, the value assigned to the shell variable is the > same.
Is it? > diff --git a/gcc/Makefile.in b/gcc/Makefile.in > index d186d71c91e..3196e774a26 100644 > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -3538,7 +3538,7 @@ install-plugin: installdirs lang.install-plugin > s-header-vars install-gengtype > # We keep the directory structure for files in config or c-family and .def > # files. All other files are flattened to a single directory. > $(mkinstalldirs) $(DESTDIR)$(plugin_includedir) > -headers=`echo $(PLUGIN_HEADERS) $$(cd $(srcdir); echo *.h *.def) | tr ' ' > '\012' | sort -u`; \ > +headers=$(sort $(PLUGIN_HEADERS) $$(cd $(srcdir); echo *.h *.def)); \ This sorts the words $(PLUGIN_HEADERS) '$(cd' $(srcdir); echo '*.h' '*.def)' and produces a command line that doesn't make sense. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
