Hi Segher,
On 2019/4/16 PM6:54, Segher Boessenkool wrote:
> Hi Xiong,
>
> Sorry I took so long to review this.
>
> On Thu, Apr 04, 2019 at 02:49:29AM -0500, luo...@linux.ibm.com wrote:
>> These patches are followed changes for r255555 on testcases
>> vsx-vector-6*.c. backport them to update file names and fix regressions
>> for GCC7 on power9.
>
> (See e.g. https://gcc.gnu.org/ml/gcc-testresults/2019-04/msg01868.html for
> the failures this patch fixes; the patch is for GCC 7).
>
>> gcc/ChangeLog:
>>
>> 2019-04-03 Xiong Hu Luo <luo...@linux.ibm.com>
>>
>> backport from trunk r260623.
>>
>> 2018-05-23 Segher Boessenkool <seg...@kernel.crashing.org>
>>
>> * doc/sourcebuild.texi (Endianness): New subsubsection.
>
> We write the changelog like
>
> 2019-04-16 Xiong Hu Luo <luo...@linux.ibm.com>
>
> Backport from trunk
> 2018-05-23 Segher Boessenkool <seg...@kernel.crashing.org>
>
> * doc/sourcebuild.texi (Endianness): New subsubsection.
>
> (no revision number, capital on Backport, no empty line after it).
>
>> 2019-04-03 Xiong Hu Luo <luo...@linux.ibm.com>
>>
>> backport from trunk r257541.
>>
>> 2018-02-07 Will Schmidt <will_schm...@vnet.ibm.com>
>>
>> * gcc.target/powerpc/vsx-vector-6-le.c: Update CPU target.
>> * gcc.target/powerpc/vsx-vector-6-le.p9.c: New.
>
> Only one space after : please.
>
>> 2018-05-04 Carl Love <c...@us.ibm.com>
>
> Two spaces between date and name.
>
>> * gcc.target/powerpc/vsx-vector-6-le.c: Add le qualifiers as needed for
>> the various instruction counts. Rename file to vsx-vector-6.p8.c.
>
> There's a tab after "to" here, should be a space.
>
>
> Other than those nits, okay for the GCC 7 branch, thanks!
I will modify all the ChangeLog nits by copy-paste, thanks.
>
> ("be" and "le" are essentially PowerPC-specific selectors on the 7 branch,
> otherwise you'd need a release manager's approval as well).
Do you mean move the "be" and "le" code from
gcc/testsuite/lib/target-supports.exp to
gcc/testsuite/gcc.target/powerpc/powerpc.exp here? I tried this, it can
work.
This require ChangeLog update as below? Or rewrite all the ChangeLog
with mine signed-of-by?
2018-05-23 Segher Boessenkool <seg...@kernel.crashing.org>
* lib/target-supports.exp (check_effective_target_be): New.
(check_effective_target_le): New.
=>
2018-05-23 Segher Boessenkool <seg...@kernel.crashing.org>
* gcc.target/powerpc/powerpc.exp
(check_effective_target_be): New.
(check_effective_target_le): New.
Also need update the "doc/sourcebuild.texi" from "+@subsubsection
Endianness" to "+@subsubsection Endianness For powerpc".
Thanks
Xiong Hu
>
>
> Segher
>
