On 4/15/19 7:12 AM, Christophe Lyon wrote: > On Sat, 13 Apr 2019 at 00:38, Martin Sebor <mse...@gmail.com> wrote: >> >> On 4/12/19 3:42 PM, Jakub Jelinek wrote: >>> On Fri, Apr 12, 2019 at 10:45:25AM -0600, Jeff Law wrote: >>>>> gcc/ChangeLog: >>>>> >>>>> PR c/89797 >>>>> * targhooks.c (default_vector_alignment): Avoid assuming >>>>> argument fits in SHWI. >>>>> * tree.h (TYPE_VECTOR_SUBPARTS): Avoid sign overflow in >>>>> a shift expression. >>>>> >>>>> gcc/c-family/ChangeLog: >>>>> >>>>> PR c/88383 >>>>> PR c/89288 >>>>> PR c/89798 >>>>> PR c/89797 >>>>> * c-attribs.c (type_valid_for_vector_size): Detect excessively >>>>> large sizes. >> ... >>> >>> Has the patch been tested at all? >> >> A few times. The c-attribs.c change above didn't make it into >> the commit. > > Hi, > Even with r270331, I'm still seeing the ICE on aarch64 (actually with > trunk @r270370) > > Is there still some commit missing? > Or perhaps something else broken. My tester flagged these are aarch64
> New tests that FAIL (4 tests): > > gcc.dg/attr-vector_size.c (internal compiler error) > gcc.dg/attr-vector_size.c (test for excess errors) > gcc.dg/attr-vector_size.c LP64 (test for errors, line 33) > gcc.dg/attr-vector_size.c LP64 (test for errors, line 60) The rest of the tests passed. It could well be something different about the aarch64 port. Seems like a bit of debugging is advisable. jeff
