Hi Erik, > On 4 Apr 2019, at 12:56, Erik Schnetter <schnet...@gmail.com> wrote: > > On Thu, Apr 4, 2019 at 3:11 AM Iain Sandoe <idsan...@googlemail.com> wrote:
> What doesn't work was that this requires changing <sys/ucred.h>. If only > <sys/sysctl.h> can be changed, then it is not possible to replace _Atomic > ulong by _Atomic(ulong) (adding parentheses). I'll try fixincluding both > files. That might be what’s needed (although both fixes really need to be conditional on the same guard). Please note the additional comments in the PR (this is potentially an ABI breaking change, but then I suppose so is the SDK change). We should at minimum test that the size and alignment of the types are the same! It’s somewhat of an additional problem that we can’t easily check for the SDK version to base fixes on known broken SDKs - it’s not really an issue of the OS revision (we’re relying on the match case + the OS version being unique ‘enough’). again, thanks for working on this, Iain
