On 3/29/19 6:31 AM, zhroma wrote:
> Martin Sebor wrote 2019-03-28 22:44:
>> On 3/28/19 11:49 AM, Roman Zhuykov wrote:
>>> Ping
>>>
>>> A week ago I decided it is so minor that I can report here with a
>>> patch without creating bugzilla PR.
>>> Technically it is a "9 regression" in new functionality added back in
>>> summer.
>>>
>>> Patch was succesfully bootstrapped and regtested on x86_64.
>>>
>>> Ok for trunk?
>>
> 
> Have found an option, which passes buggy function and all subsequent
> checks:
> "-fdiagnostics-minimum-margin-width=-1" gives an error, but
> "-fdiagnostics-minimum-margin-width=42xyz" silently sets it to -1 :)
> 
>> Thanks for the patch!  The change makes sense to me.  Can you
>> please also add a test case to the test suite?
> 
> Added the test, is such filename (and contents) ok ?
> 
>> I can't approve patches, even obvious ones, so please wait for
>> an approval from a maintainer before committing it.
> 
> CC'ed to "option handling" maintainer here.
> 
> -- 
> Roman
> 
> 
> gcc/testsuite/ChangeLog:
> 
> 2019-03-29  Roman Zhuykov  <zhr...@ispras.ru>
> 
>     * gcc.dg/diag-sanity.c: New test.
> 
> 
> gcc/ChangeLog:
> 
> 2019-03-29  Roman Zhuykov  <zhr...@ispras.ru>
> 
>     * opts-common.c (integral_argument): Set errno properly in one case.
Thanks.  I ran this through  my tester (no regressions, as expected) and
installed it on the trunk.

Jeff

Reply via email to