On Wed, Mar 27, 2019 at 11:12:38PM +0100, Janus Weil wrote: > Hi Steve, > > > > the attached patch implements some missing constraints from Fortran > > > 2008 concerning procedure pointer initialization (cf. the standard > > > quote in comment #18), thus fixing two accepts-invalid and > > > ICE-on-invalid problems. > > > > > > It regtests cleanly on x86_64-linux-gnu. Ok for trunk? > > > > Looks OK to me. Just minor comment. If there are numbered > > constraints in either F2008 or F2018 for each of the if() > > conditionals, can you add a comment. > > I fully agree. Luckily the reference to F08:C1220 is already present > in gfc_check_assign_symbol (but unfortunately not visible in the > diff), and it applies in the same way to the one IF clause that is > already there as well as the two new ones I'm adding, which is why I'm > not putting in an additional reference. >
Ah, ok. Thanks for the reply. -- Steve