Hello Eric, 2011/11/11 Eric Botcazou <ebotca...@adacore.com>: >> Great! I'll be back with patch covering all non functional changes. >> Will it be OK to have everything in one patch (including current >> functional changes) or I should split it? > > Let's also rename the file while we are at it. I'd suggest Redundant > Extension > Elimination for the name of the pass, so ree.c for the filename (suggestions > for a more descriptive name welcome). So we rename implicit-zee.c into ree.c > and add a new header along these lines: > > /* Redundant Extension Elimination pass for the GNU compiler. > Copyright (C) 2010-2011 Free Software Foundation, Inc. > Contributed by <you> > > Based on the Redundant Zero-extension elimination pass contributed by > Sriraman Tallam (tmsri...@google.com) and Silvius Rus (r...@google.com). > > This file is part of GCC. > [...] > > The general comment must be adjusted: "Problem Description" extended, "How > does > this pass work" adjusted and so on. Hardcoded references to zero-extensions > and specific pair of modes, both in the comment and the function names, must > be eliminated. > > Since implicit-zee.c has essentially no revision history (the original commit > + > a patch of mine to fix rough edges), let's pretend we start from scratch, so > the ChangeLog will be > > > * implicit-zee.c: Delete. > * ree.c: New file. > [...] > > and you post the complete file. I'll do the review. > > Last but not least, since this is a significant contribution, you need to have > a copyright assignment on file with the FSF in order for us to accept it. > > -- > Eric Botcazou >
Thanks for tips! I'll do these changes after my two weeks vacation or my colleges will cover me. I have already signed copyright agreement with the FSF. Will I need the separate one for this particular commit? Thanks Ilya
