On Mon, 18 Mar 2019, David Malcolm wrote: > Here's a patch for the website to add my changes for GCC 9 (bearing > a strong resemblance to my recent blog post)
Wow, that. is. a. lot! :-) > -<a href="porting_to.html">Porting to GCC 8</a> page and the > +<a href="porting_to.html">Porting to GCC 9</a> page and the Good catch! > + <p> > + GCC's diagnostics now print a left-margin when printing source code > + (via the default <a > href="https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-show-caret";>-fdiagnostics-show-caret</a>), > + showing line numbers. This can be disabled via <a > href="https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Formatting-Options.html#index-fno-diagnostics-show-line-numbers";>-fno-diagnostics-show-line-numbers</a>. Can you think of a good way to avoid "print" and "printing" so closely together? A most minor detail, but I think we usually want to avoid such cases if possible? > + GCC's diagnostics can also now label regions of the source code to > + show pertinent information, such as the types within an expression. > + </p> > +<pre class="blackbg"> I'm wondering whether we should perhaps introduce a new class such as "diagnosticsexample" (or shorter)? Logical markup instead of physical markup is the way to go, and right now "blackbg" only appears to be used in gcc-8/changes.html and only for diagnostics, > + A new option <a > href="https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Formatting-Options.html#index-fdiagnostics-format";>-fdiagnostics-format=json</a> > + has been introduced, for emitting diagnostics in a machine-readable > + format. No comma before "for emitting"? > + <p>Numerous improvements have been made to the output of <a > href="https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#index-fopt-info";>-fopt-info</a>.</p> Some lines, like this, are really quite long. Indeed some of them, in particular those with longer links, do not fit 80 characters, but usually we try to break up lines to the extent possible then, so before the link in this case. > + The old behavior can be obtained via a new <code>-internals</code> > + suboption of <code>-fopt-info</code>. A concrete usage example might be good here, i.e., how does a suboption look like here? > + If a macro is used with the wrong argument count, the C and C++ front > + ends now show the definition of the macro via a <code>note</code>. "that macro" instead of the "the macro" perhaps, to emphasize a bit more? > + The C++ front end now preserves source locations for longer for > + literals, <code>id-expression</code> and <code>mem-initializer</code>. Comma before "and"? And "for longer" at the end? > + The C++ front end's implementation of <a > href="https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat";>-Wformat</a> > + now shows precise locations within string literals, and underlines > + the pertinent arguments at bogus call sites (the C front end has done > + this since GCC 7). For example: "...C front end has been doing this..."? Thanks for those contributions _and_ taking the time to document them! You may have noticed that nearly everything above is a question. Please take the feedback into account, but do not feel obliged to make all those changes. Okay (with or without some of those changes above). Gerald
