Ping.
> -----Original Message----- > From: Tamar Christina <tamar.christ...@arm.com> > Sent: Thursday, February 7, 2019 10:43 > To: Tamar Christina <tamar.christ...@arm.com>; Jakub Jelinek > <ja...@redhat.com> > Cc: Kyrill Tkachov <kyrylo.tkac...@foss.arm.com>; gcc-patches@gcc.gnu.org; > nd <n...@arm.com>; James Greenhalgh <james.greenha...@arm.com>; > Richard Earnshaw <richard.earns...@arm.com>; Marcus Shawcroft > <marcus.shawcr...@arm.com> > Subject: RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored > during native feature detection > > Hi All, > > Since this hasn't been reviewed yet anyway I've updated this patch to also fix > the memory leaks etc. > > -- > > This patch makes the feature detection code for AArch64 GCC not add > features automatically when the feature had no hwcaps string to match > against. > > This means that -mcpu=native no longer adds feature flags such as +profile. > The behavior wasn't noticed before because at the time +profile was added > a bug was preventing any feature bits from being added by native detections. > > The loop has also been changed as Jakub specified in order to avoid a > memory leak that was present in the existing code and to be slightly more > efficient. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for trunk? > > Thanks, > Tamar > > gcc/ChangeLog: > > 2019-02-07 Tamar Christina <tamar.christ...@arm.com> > > PR target/88530 > * config/aarch64/aarch64-option-extensions.def: Document it. > * config/aarch64/driver-aarch64.c (host_detect_local_cpu): Skip > feature > if empty hwcaps. > > gcc/testsuite/ChangeLog: > > 2019-02-07 Tamar Christina <tamar.christ...@arm.com> > > PR target/88530 > * gcc.target/aarch64/options_set_10.c: New test. > > > -----Original Message----- > > From: gcc-patches-ow...@gcc.gnu.org <gcc-patches-ow...@gcc.gnu.org> > On > > Behalf Of Tamar Christina > > Sent: Wednesday, January 30, 2019 14:48 > > To: Jakub Jelinek <ja...@redhat.com> > > Cc: Kyrill Tkachov <kyrylo.tkac...@foss.arm.com>; > > gcc-patches@gcc.gnu.org; nd <n...@arm.com>; James Greenhalgh > > <james.greenha...@arm.com>; Richard Earnshaw > > <richard.earns...@arm.com>; Marcus Shawcroft > > <marcus.shawcr...@arm.com> > > Subject: Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored > > during native feature detection > > > > Hi Jakub, > > > > On Wed, Jan 30, 2019 at 02:06:01PM +0000, Tamar Christina wrote: > > > > Thanks for the feedback, but I think those are changes for another > patch. > > > > > > At least the memory leak is something that should be fixed even in > > > stage4 IMNSHO. > > > > I'll provide a separate patch for this then. > > > > > Anyway, will defer to aarch64 maintainers here. > > > > > Just one question, for the *feat_string == '\0' case, is continue > > > what you want, rather than just enabled = false; and doing the > > > extension_flags &= ~(aarch64_extensions[i].flag); > > > later on? > > > > Yeah, because the feature may be on by default due to another > > extension, in which case you would erroneously turn it off. The > > absence of an HWCAPS shouldn't pro-actively disable an extension. > > > > Regards, > > Tamar
