On 2/15/19 6:57 PM, Sandra Loosemore wrote:
On 2/6/19 9:16 AM, Martin Sebor wrote:
The manual documents the -Wno-missing-attributes form of the option
as if it was enabled by default, even though it's enabled by -Wall
(I can't get this -Wno- convention straight in my head). I also
got private comments on the documentation of the option suggesting
to add cross-references, and to list the attributes
-Wattribute-alias considers (the same ones as -Wmissing-attributes).
The attached patch makes these changes.
I found the discussion of both options incomprehensible even with this
patch. :-( The defaults are incorrect, there are typos, awkward
wording and confusing paragraph organization, etc. So I consulted the
sources and came up with the attached alternative patch. Can you review
this for correctness and generally making sense?
2019-02-15 Sandra Loosemore <san...@codesourcery.com>
Martin Sebor <mse...@gmail.com>
gcc/
* c-family/c.opt (Wmissing-attributes): Clean up doc string.
* common.opt (Wattribute-alias): Likewise.
* doc/invoke.texi (Option Summary): List general form of
-Wattribute-alias=. List positive form of -Wmissing-attributes.
(-Wmissing-attributes): Invert entry, rewrite and correct default.
Add cross-references.
(-Wattribute-alias): Rewrite and correct default. Mention
considered attributes (same as for -Wmissing-attributes).
Any thoughts on this patch? I'll go ahead and commit it if I don't hear
any objection in the next couple of days.... it can't be any worse than
the existing documentation. :-P
-Sandra
