On 2/21/19 1:35 PM, Marek Polacek wrote:
We were ICEing because we called build_converted_constant_expr on an expression that wasn't value-dependent, but it still contained template codes, and that didn't work too well because check_narrowing calls maybe_constant_value.
Hmm, I'm concerned about convert_like_real from build_converted_constant_expr adding more template codes; you probably want a processing_template_decl_sentinel after the instantiate_non_dependent_expr.
Also, value_dependent_expression_p should probably be instantiation_dependent_expression_p.
Jason
