Re: [PATCH 2/2][GCC][Arm] Update Armv8.4-a's FP16 FML intrinsics

Thu, 21 Feb 2019 08:29:22 -0800 

Hi Tamar,

On 2/20/19 1:59 PM, Tamar Christina wrote:

Hi All,
This patch updates the Armv8.4-a FP16 FML intrinsics's suffixes from u32 to f16 
to be more consistent with the naming convention for intrinsics.
The specifications for these intrinsics have not been published yet so we do 
not need to maintain the old names.

The patch was created with the following script:

grep -lIE "(vfml[as].+)_u32" -r gcc/ | grep -iEv ".+Changelog.*" \
  | xargs sed -i -E -e "s/(vfml[as].+)_u32/\1_f16/g"

Bootstrapped Regtested on arm-none-gnueabihf and no issues.

Ok for trunk? and eventual backport to GCC 8?
Ok, but please only commit this together with the AArch64 patch if it's approved. 

I'd rather we be consistent with aarch64 on this.

Thanks,

Kyrill



Thanks,
Tamar

gcc/ChangeLog:

2019-02-20  Tamar Christina  <tamar.christ...@arm.com>

        * config/arm/arm_neon.h (vfmlal_low_u32, vfmlsl_low_u32,
        vfmlal_high_u32, vfmlsl_high_u32, vfmlalq_low_u32, vfmlslq_low_u32, 
        vfmlalq_high_u32, vfmlslq_high_u32, vfmlal_lane_low_u32,
        vfmlal_lane_high_u32, vfmlalq_laneq_low_u32, vfmlalq_lane_low_u32,
        vfmlal_laneq_low_u32, vfmlalq_laneq_high_u32, vfmlalq_lane_high_u32, 
        vfmlal_laneq_high_u32, vfmlsl_lane_low_u32, vfmlsl_lane_high_u32,
        vfmlslq_laneq_low_u32, vfmlslq_lane_low_u32, vfmlsl_laneq_low_u32,
        vfmlslq_laneq_high_u32, vfmlslq_lane_high_u32, vfmlsl_laneq_high_u32): 
        Rename ...
        (vfmlal_low_f16, vfmlsl_low_f16, vfmlal_high_f16, vfmlsl_high_f16,
        vfmlalq_low_f16, vfmlslq_low_f16, vfmlalq_high_f16, vfmlslq_high_f16, 
        vfmlal_lane_low_f16, vfmlal_lane_high_f16, vfmlalq_laneq_low_f16,
        vfmlalq_lane_low_f16, vfmlal_laneq_low_f16, vfmlalq_laneq_high_f16, 
        vfmlalq_lane_high_f16, vfmlal_laneq_high_f16, vfmlsl_lane_low_f16,
        vfmlsl_lane_high_f16, vfmlslq_laneq_low_f16, vfmlslq_lane_low_f16,
        vfmlsl_laneq_low_f16, vfmlslq_laneq_high_f16, vfmlslq_lane_high_f16, 
        vfmlsl_laneq_high_f16): ... To this.
        * config/arm/neon.md: Update comments.

gcc/testsuite/ChangeLog:

2019-02-20  Tamar Christina  <tamar.christ...@arm.com>

        * gcc.target/arm/simd/fp16fml_high.c (test_vfmlal_high_u32,
        test_vfmlalq_high_u32, test_vfmlsl_high_u32, test_vfmlslq_high_u32): 
        Rename ....
        (test_vfmlal_high_f16, test_vfmlalq_high_f16, test_vfmlsl_high_f16, 
        test_vfmlslq_high_f16): ... To this.
        * gcc.target/arm/simd/fp16fml_lane_high.c (test_vfmlal_lane_high_u32, 
        tets_vfmlsl_lane_high_u32, test_vfmlal_laneq_high_u32,
        test_vfmlsl_laneq_high_u32, test_vfmlalq_lane_high_u32,
        test_vfmlslq_lane_high_u32, test_vfmlalq_laneq_high_u32,
        test_vfmlslq_laneq_high_u32): Rename ...
        (test_vfmlal_lane_high_f16, tets_vfmlsl_lane_high_f16,
        test_vfmlal_laneq_high_f16, test_vfmlsl_laneq_high_f16,
        test_vfmlalq_lane_high_f16, test_vfmlslq_lane_high_f16,
        test_vfmlalq_laneq_high_f16, test_vfmlslq_laneq_high_f16): ... To this.         * gcc.target/arm/simd/fp16fml_lane_low.c (test_vfmlal_lane_low_u32, 
        test_vfmlsl_lane_low_u32, test_vfmlal_laneq_low_u32,
        test_vfmlsl_laneq_low_u32, test_vfmlalq_lane_low_u32,
        test_vfmlslq_lane_low_u32, test_vfmlalq_laneq_low_u32,
        test_vfmlslq_laneq_low_u32): Rename ...
        (test_vfmlal_lane_low_f16, test_vfmlsl_lane_low_f16,
        test_vfmlal_laneq_low_f16, test_vfmlsl_laneq_low_f16,
        test_vfmlalq_lane_low_f16, test_vfmlslq_lane_low_f16,
        test_vfmlalq_laneq_low_f16, test_vfmlslq_laneq_low_f16): ... To this. 
        * gcc.target/arm/simd/fp16fml_low.c (test_vfmlal_low_u32,
        test_vfmlalq_low_u32, test_vfmlsl_low_u32, test_vfmlslq_low_u32):
        Rename ...
        (test_vfmlal_low_f16, test_vfmlalq_low_f16, test_vfmlsl_low_f16,
        test_vfmlslq_low_f16): ... To this.

--

Reply via email to