Hi Chung-Lin!
On Tue, 22 Jan 2019 13:16:37 +0100, I wrote:
> On Mon, 14 Jan 2019 21:56:05 +0800, Chung-Lin Tang <chunglin_t...@mentor.com>
> wrote:
> > this version of the wait-clause-with-no-args patch revises the following:
> Thanks.
>
> > Hope this is now okay for trunk when appropriate.
>
> Given that this is a wrong-code generation bug fix, I do approve this in
> the current GCC development stage (and will later backport to the other
> release branches), but please include the following changes as discussed
> before: mention PR87924 "OpenACC wait clauses without async-arguments" in
> the ChangeLogs and commit log
Thanks for committing this, trunk r269016.
> and remove the XFAILs in
> "c-c++-common/goacc/asyncwait-5.c" and "gfortran.dg/goacc/asyncwait-5.f".
This I now have done myself, in trunk r269020 "[PR87924] OpenACC wait
clauses without async-arguments: remove XFAILs", attached.
Grüße
Thomas
>From 3eedad7ade57021a843447e8b6cba9619ac5b39e Mon Sep 17 00:00:00 2001
From: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Tue, 19 Feb 2019 16:04:17 +0000
Subject: [PATCH] [PR87924] OpenACC wait clauses without async-arguments:
remove XFAILs
... which the recent r269016 didn't do.
gcc/testsuite/
PR c/87924
* c-c++-common/goacc/asyncwait-5.c: Remove XFAILs.
* gfortran.dg/goacc/asyncwait-5.f: Likewise.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@269020 138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/testsuite/ChangeLog | 6 ++++++
gcc/testsuite/c-c++-common/goacc/asyncwait-5.c | 10 +++++-----
gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f | 10 +++++-----
3 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5796a150c0d..1c91cec1a81 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-02-19 Thomas Schwinge <tho...@codesourcery.com>
+
+ PR c/87924
+ * c-c++-common/goacc/asyncwait-5.c: Remove XFAILs.
+ * gfortran.dg/goacc/asyncwait-5.f: Likewise.
+
2019-02-19 H.J. Lu <hongjiu...@intel.com>
PR target/89397
diff --git a/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c b/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c
index 80d4a8477b9..f4ba48a1833 100644
--- a/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c
+++ b/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c
@@ -15,21 +15,21 @@ void f()
#pragma acc parallel async (3) wait
;
- /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) async\\(3\\)$" 1 "original" { xfail *-*-* } } } */
+ /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) async\\(3\\)$" 1 "original" } } */
#pragma acc parallel async (4) wait (100) wait
;
- /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) wait\\(100\\) async\\(4\\)$" 1 "original" { xfail *-*-* } } } */
+ /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) wait\\(100\\) async\\(4\\)$" 1 "original" } } */
#pragma acc parallel async (5) wait wait (101)
;
- /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(101\\) wait\\(-1\\) async\\(5\\)$" 1 "original" { xfail *-*-* } } } */
+ /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(101\\) wait\\(-1\\) async\\(5\\)$" 1 "original" } } */
#pragma acc parallel async (6) wait wait (102, 103) wait wait
;
- /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) wait\\(-1\\) wait\\(103\\) wait\\(102\\) wait\\(-1\\) async\\(6\\)$" 1 "original" { xfail *-*-* } } } */
+ /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(-1\\) wait\\(-1\\) wait\\(103\\) wait\\(102\\) wait\\(-1\\) async\\(6\\)$" 1 "original" } } */
#pragma acc parallel async (7) wait (104) wait wait (105, 106)
;
- /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(106\\) wait\\(105\\) wait\\(-1\\) wait\\(104\\) async\\(7\\)$" 1 "original" { xfail *-*-* } } } */
+ /* { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel wait\\(106\\) wait\\(105\\) wait\\(-1\\) wait\\(104\\) async\\(7\\)$" 1 "original" } } */
}
diff --git a/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f b/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f
index 7ad5813b8a0..89cd7923590 100644
--- a/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f
+++ b/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f
@@ -12,22 +12,22 @@
!$ACC PARALLEL ASYNC (3) WAIT
!$ACC END PARALLEL
-! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(3\\) wait\\(-1\\)$" 1 "original" { xfail *-*-* } } }
+! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(3\\) wait\\(-1\\)$" 1 "original" } }
!$ACC PARALLEL ASYNC (4) WAIT (100) WAIT
!$ACC END PARALLEL
-! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(4\\) wait\\(100\\) wait\\(-1\\)$" 1 "original" { xfail *-*-* } } }
+! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(4\\) wait\\(100\\) wait\\(-1\\)$" 1 "original" } }
!$ACC PARALLEL ASYNC (5) WAIT WAIT (101)
!$ACC END PARALLEL
-! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(5\\) wait\\(-1\\) wait\\(101\\)$" 1 "original" { xfail *-*-* } } }
+! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(5\\) wait\\(-1\\) wait\\(101\\)$" 1 "original" } }
!$ACC PARALLEL ASYNC (6) WAIT WAIT (102, 103) WAIT WAIT
!$ACC END PARALLEL
-! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(6\\) wait\\(-1\\) wait\\(102\\) wait\\(103\\) wait\\(-1\\) wait\\(-1\\)$" 1 "original" { xfail *-*-* } } }
+! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(6\\) wait\\(-1\\) wait\\(102\\) wait\\(103\\) wait\\(-1\\) wait\\(-1\\)$" 1 "original" } }
!$ACC PARALLEL ASYNC (7) WAIT (104) WAIT WAIT (105, 106)
!$ACC END PARALLEL
-! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(7\\) wait\\(104\\) wait\\(-1\\) wait\\(105\\) wait\\(106\\)$" 1 "original" { xfail *-*-* } } }
+! { dg-final { scan-tree-dump-times "(?n)#pragma acc parallel async\\(7\\) wait\\(104\\) wait\\(-1\\) wait\\(105\\) wait\\(106\\)$" 1 "original" } }
END
--
2.17.1
