On Thu, Feb 14, 2019 at 12:43 PM Uros Bizjak <ubiz...@gmail.com> wrote:
>
> On Thu, Feb 14, 2019 at 9:21 PM Uros Bizjak <ubiz...@gmail.com> wrote:
> >
> > On Thu, Feb 14, 2019 at 1:30 PM H.J. Lu <hjl.to...@gmail.com> wrote:
> > >
> > > Since we now emulate MMX intrinsics with SSE in 64-bit mode, we can
> > > enable SSSE3 __m64 tests even when AVX is enabled.
> > >
> > >         PR target/89021
> > >         * gcc.target/i386/ssse3-pabsb.c: Also enable __m64 check in
> > >         64-bit mode.
> > >         * gcc.target/i386/ssse3-pabsd.c: Likewise.
> > >         * gcc.target/i386/ssse3-pabsw.c: Likewise.
> > >         * gcc.target/i386/ssse3-palignr.c: Likewise.
> > >         * gcc.target/i386/ssse3-phaddd.c: Likewise.
> > >         * gcc.target/i386/ssse3-phaddsw.c: Likewise.
> > >         * gcc.target/i386/ssse3-phaddw.c: Likewise.
> > >         * gcc.target/i386/ssse3-phsubd.c: Likewise.
> > >         * gcc.target/i386/ssse3-phsubsw.c: Likewise.
> > >         * gcc.target/i386/ssse3-phsubw.c: Likewise.
> > >         * gcc.target/i386/ssse3-pmaddubsw.c: Likewise.
> > >         * gcc.target/i386/ssse3-pmulhrsw.c: Likewise.
> > >         * gcc.target/i386/ssse3-pshufb.c: Likewise.
> > >         * gcc.target/i386/ssse3-psignb.c: Likewise.
> > >         * gcc.target/i386/ssse3-psignd.c: Likewise.
> > >         * gcc.target/i386/ssse3-psignw.c: Likewise.
> > > ---
> > >  gcc/testsuite/gcc.target/i386/ssse3-pabsb.c     | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-pabsd.c     | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-pabsw.c     | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-palignr.c   | 6 +++---
> > >  gcc/testsuite/gcc.target/i386/ssse3-phaddd.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-phaddsw.c   | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-phaddw.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-phsubd.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-phsubsw.c   | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-phsubw.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-pmaddubsw.c | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-pmulhrsw.c  | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-pshufb.c    | 6 +++---
> > >  gcc/testsuite/gcc.target/i386/ssse3-psignb.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-psignd.c    | 4 ++--
> > >  gcc/testsuite/gcc.target/i386/ssse3-psignw.c    | 4 ++--
> > >  16 files changed, 34 insertions(+), 34 deletions(-)
> > >
> > > diff --git a/gcc/testsuite/gcc.target/i386/ssse3-pabsb.c 
> > > b/gcc/testsuite/gcc.target/i386/ssse3-pabsb.c
> > > index 7caa1b6c3a6..eef4ccae222 100644
> > > --- a/gcc/testsuite/gcc.target/i386/ssse3-pabsb.c
> > > +++ b/gcc/testsuite/gcc.target/i386/ssse3-pabsb.c
> > > @@ -15,7 +15,7 @@
> > >  #include "ssse3-vals.h"
> > >  #include <tmmintrin.h>
> > >
> > > -#ifndef __AVX__
> > > +#if !defined __AVX__ || defined __x86_64__
> >
> > Better add || defined __x86_64__.
> >
> > I also wonder why AVX has to be disabled here. MMX should be orthogonal to 
> > AVX.
>
> Actually, current trunk passes tests with #ifndef __AVX__ removed and:

I don't remember why AVX was disabled.  It is possible that AVX SDE at
the time didn't
support MMX with AVX.    Can you check in a separate patch to remove
__AVX__ check?

Thanks.

> gmake -k check-gcc
> RUNTESTFLAGS="--target_board=unix\{,-m32\}\{,-mavx\}
> i386.exp=ssse3-*.c"
>
>                 === gcc tests ===
>
> Schedule of variations:
>     unix
>     unix/-mavx
>     unix/-m32
>     unix/-m32/-mavx
>
>                 === gcc Summary ===
>
> # of expected passes            128
>
> Uros.

-- 
H.J.

Reply via email to