On Mon, Feb 11, 2019 at 3:35 AM Alan Modra <amo...@gmail.com> wrote: > > On Fri, Feb 08, 2019 at 10:51:34AM +0100, Uros Bizjak wrote: > > On Thu, Feb 7, 2019 at 10:11 PM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > OImode and TImode moves must be done in XImode to access upper 16 > > > vector registers without AVX512VL. With AVX512VL, we can access > > > upper 16 vector registers in OImode and TImode. > > > > > > PR target/89229 > > > * config/i386/i386.md (*movoi_internal_avx): Set mode to XI for > > > upper 16 vector registers without TARGET_AVX512VL. > > > (*movti_internal): Likewise. > > > > Please use (not (match_test "...")) instead of (match_test "!...") and > > I'm curious. Is there a reason other than style to ask for this > change?
It is style that we want to keep throughout i386 *.md files, otherwise, it should result in identical code. Uros.