Hi!
On Fri, 27 May 2016 08:19:56 -0700, Cesar Philippidis <ce...@codesourcery.com>
wrote:
> This patch backports the recent firstprivate subarray changes I've made
> [...]
> Thomas, I decided to xfail a bunch of kernels tests in gomp4 instead of
> removing them so that we can have a better record on what changed. [...]
The version of this patch as it is still present on openacc-gcc-8-branch
(commit 629dfb8f365caa5e8a7437459954988c60213ba0 "[OpenACC] firstprivate
subarray changes"), still does "XFAIL" the following two test cases:
> --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c
> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c
> @@ -1,3 +1,7 @@
> +/* FIXME: OpenACC kernels stopped working with the firstprivate subarray
> + changes. */
> +/* { dg-prune-output "OpenACC kernels construct will be executed
> sequentially" } */
> --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c
> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c
> @@ -1,3 +1,7 @@
> +/* FIXME: OpenACC kernels stopped working with the firstprivate subarray
> + changes. */
> +/* { dg-prune-output "OpenACC kernels construct will be executed
> sequentially" } */
I wrote "XFAIL" in quotes, because a "dg-prune-output" is not an "XFAIL",
because this can't ever turn into an "XPASS" -- which apparently would've
happened at some point: I've now pushed the attached to
openacc-gcc-8-branch.
Grüße
Thomas
From 1175533405fb2c08b2930288c30f58522ce449a6 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tho...@codesourcery.com>
Date: Tue, 29 Jan 2019 20:34:35 +0100
Subject: [PATCH] [OpenACC] firstprivate subarray changes: remove "XFAIL"s
Don't know, though, which change restored the expected "parloops" processing.
libgomp/
* testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c:
Remove "dg-prune-output".
* testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c:
Likewise.
---
libgomp/ChangeLog.openacc | 7 +++++++
.../libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c | 4 ----
.../libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c | 4 ----
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/libgomp/ChangeLog.openacc b/libgomp/ChangeLog.openacc
index cfccb835591..0387013d232 100644
--- a/libgomp/ChangeLog.openacc
+++ b/libgomp/ChangeLog.openacc
@@ -1,3 +1,10 @@
+2019-01-30 Thomas Schwinge <tho...@codesourcery.com>
+
+ * testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c:
+ Remove "dg-prune-output".
+ * testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c:
+ Likewise.
+
2019-01-29 Gergö Barany <ge...@codesourcery.com>
* testsuite/libgomp.oacc-fortran/initialize_kernels_loops.f90: New test.
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c
index d0ea230a805..e62297129fd 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-3.c
@@ -1,7 +1,3 @@
-/* FIXME: OpenACC kernels stopped working with the firstprivate subarray
- changes. */
-/* { dg-prune-output "OpenACC kernels construct will be executed sequentially" } */
-
#include <stdlib.h>
#define N 32
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c
index 4017560d0a1..c73127897a9 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/kernels-loop-and-seq-4.c
@@ -1,7 +1,3 @@
-/* FIXME: OpenACC kernels stopped working with the firstprivate subarray
- changes. */
-/* { dg-prune-output "OpenACC kernels construct will be executed sequentially" } */
-
#include <stdlib.h>
#define N 32
--
2.17.1
