On Tue, Jan 29, 2019 at 1:38 PM Jakub Jelinek <ja...@redhat.com> wrote:
>
> Emitting this warning for internal linkage functions makes no sense to me,
> the ABI of those functions is solely under control of the compiler that
> knows the callee as well as all callers and can do anything it wants.
> I've added DECL_PRESERVE_P to the test, so if somebody uses used attribute
> and accesses those from inline assembly, they get warning.

Calling an affected function from inline assembly seems extremely
unlikely, so I'd probably just check TREE_PUBLIC.  Why do you also
check DECL_EXTERNAL?

Jason

Reply via email to