Hi Kelvin, On Mon, Jan 28, 2019 at 12:11:34PM -0600, Kelvin Nilsen wrote: > An error in the type returned from the built-in vec_extract function was > recently reported, as represented in the following sample program:
[ snip ] > The fix is to coerce the result of vec_extract so that it matches the type of > the array element supplied as its first argument. The patch is fine, but there are some issues with the new testcases: > --- gcc/testsuite/gcc.target/powerpc/vec-extract-schar-1.c (nonexistent) > +++ gcc/testsuite/gcc.target/powerpc/vec-extract-schar-1.c (working copy) > @@ -0,0 +1,27 @@ > +/* Test to verify that the vec_extract from a vector of > + signed chars remains signed. */ > +/* { dg-do run } */ > +/* { dg-options "-ansi -mcpu=power8 " } */ (stray space) You need to also have /* { dg-require-effective-target powerpc_p8vector_ok } */ /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */ (the first so that the builtins exist, the second so that things work if you set -mcpu= in RUNTESTFLAGS, as is common). Could you test with that please? Okay for trunk with that. Also okay for backport where wanted/needed. Thanks! Segher