On Sat, Jan 26, 2019 at 01:25:04AM +0000, Joseph Myers wrote:
> It's also broken the build of the glibc testsuite, e.g.:
>
> ../time/time.h:88:15: error: mismatch in argument 1 type of built-in function
> 'strftime'; expected 'char *' [-Werror=builtin-declaration-mismatch]
> 88 | extern size_t strftime (char *__restrict __s, size_t __maxsize,
>
> (presence or absence of qualifiers on a parameter is not part of the
> function type and should not be compared here).
There are several further issues, even after fixing the toplevel qualifiers on
arguments as well as return type + fixing up the testcases, there is another
problem, the code has the magic handling only for fileptr_type_node, but we
actually need handling for all builtin_structptr_types struct types,
otherwise e.g. for strftime we warn that the last argument should not be
const struct tm *, but const void *, when it actually should be const struct
tm *.
Working on it.
Jakub
