On 1/25/19 5:28 AM, Tom de Vries wrote:

This patch fixes it by passing "" instead of NULL, in the call to
elf_add at line 3083 (for .gnu_debugaltlink), not the call to elf_add at
line 3044 (for .gnu_debuglink) mentioned above.

Nathan, does this fix the problem for you? If not, can you provide a
reproducer, or give a hint on how one could be constructed?

I still hit the problem, and am installing this as sufficiently obvious. I'm on a fedora system debugging pr88995. The debuglink_name is "../../.dwz/isl-0.16.1-7.fc29.x86_64"

I'm not sure why this is triggering now -- maybe my debuginfo packages are out of date?

nathan

--
Nathan Sidwell
2019-01-25  Nathan Sidwell  <nat...@acm.org>

	* elf.c (elf_add): Pass "" filename to recursive call with
	separated debug.

Index: elf.c
===================================================================
--- elf.c	(revision 268272)
+++ elf.c	(working copy)
@@ -3041,7 +3041,7 @@ elf_add (struct backtrace_state *state,
 	  if (debugaltlink_view_valid)
 	    backtrace_release_view (state, &debugaltlink_view, error_callback,
 				    data);
-	  ret = elf_add (state, NULL, d, base_address, error_callback, data,
+	  ret = elf_add (state, "", d, base_address, error_callback, data,
 			 fileline_fn, found_sym, found_dwarf, NULL, 0, 1, NULL,
 			 0);
 	  if (ret < 0)

Reply via email to