Steve Ellcey <sell...@marvell.com> writes:
> On Wed, 2019-01-23 at 16:54 +0000, Richard Sandiford wrote:
>> 
>> IMO we shouldn't remove the assert.  See:
>> 
>>   https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01969.html
>> 
>> and the thread leading up to it.
>> 
>> Thanks,
>> Richard
>
> OK, I hadn't seen that thread.  I didn't see any patch submitted

Yeah, I kept meaning to get round to it but never did...

> in response to your comment there so I created a new patch.
> This patch leaves the assert in aarch64.c and changes the check
> for the 'p' constraint in constain_operands, this version
> fixes the pr84682-2.c test failure and causes no regressions
> on aarch64 or x86.

Great!

> Steve Ellcey
> sell...@marvell.com
>
>
> 2019-01-23  Bin Cheng  <bin.ch...@arm.com>
>           Steve Ellcey <sell...@marvell.com>
>
>       PR target/85711
>       * recog.c (address_operand): Return false on wrong mode for address.
>       (constrain_operands): Check for mode with 'p' constraint.

OK, thanks.

Richard

Reply via email to