Am 22.01.2019 um 14:21 schrieb Dominique d'Humières:
> 
> 
>> Le 22 janv. 2019 à 10:02, Manfred Schwarb <manfre...@gmx.ch> a écrit :
>>
>> Dominique, thanks a lot.
>>
>> I got the request to share my script, so I attached it to this mail.
>> Be aware that the script reports numerous false positives.
>> As one can expect, also gcc.dg would appreciate some love…
> 
> I had a quick look at the script and noticed that the paths are hard-coded.
> Assuming the script is going to contrib/, would it be possible to replace 
> them with
> relative ones? Some comments to explain how to use it would also be nice.
> 
> Note that I have no idea if this script requires a copyright assignment.
> 

I do not have an assignment, and frankly, I do not intend to get one.
But I could donate this code to someone, if this helps.
My expectation was that one has to edit the script anyway to adapt it to
different test-suites or to fiddle with filtering. I guess this script is
very far from perfect.

>>
>> While cleaning up the script, I found some refinements, and another
>> 7 glitches, see attachment.
>>
>> could you take care of these as well?
> 
> Done at r268148 after removing a missed double spaces in 
> gfortran.dg/spread_simplify_1.f90 
> and renaming  gfortran.dg.orig/newunit_5.f90.f90 to 
> gfortran.dg.orig/newunit_5.f90.
> 

I guess "dg-do  run" was on purpose, this is an ugly hack to execute the test 
only once
and not iterate over the full set of options. This is often done on 
heavy-weight tests
to save execution time.

> Thanks,
> 
> Dominique
> 
>>
>> Cheers, Manfred
>>
>>
>> Am 21.01.2019 um 22:47 schrieb Dominique d'Humières:
>>> Hi Manfred,
>>>
>>>> could someone please check and commit?
>>>
>>> Tested and committed as obvious at r268125.
>>>
>>> Thanks for the patch.
>>>
>>> Dominique
>>>
>>>
>>
>> <testsuite-test.sh><directives2.patch>
> 
> 

Reply via email to