On Tue, 15 Jan 2019, Jason Merrill wrote: > I actually incorporated the C++ part of these changes into yesterday's commit, > using Martin's first suggestion. Here's the adjusted C patch, which I'd like > a C maintainer to approve.
The front-end changes are OK. However, in the testcase changes, some of the new expected diagnostics are hardcoding that "unsigned int" is the type of char32_t, which isn't correct for all platforms (for example, it's definitely not the type when int is 16-bit). In principle the same applies to diagnostics hardcoding the choice of char16_t, although variations are at least less likely there. -- Joseph S. Myers jos...@codesourcery.com
