Jeff Law <l...@redhat.com> writes: > On 1/10/19 12:19 AM, Alan Modra wrote: >> bb-reorder is quite seriously broken if get_attr_min_length should >> return INT_MAX, which it does for hppa on branches with r267666. > Presumably you're referring to the overflows and such? > > >> >> I went the wrong way with my min_attr_value r267666 change. It seems >> that it isn't important that a "can't calculate" value is returned >> from recursive calls, but rather that it returns the minimum among >> those the function can calculate, ie. a conservative minimum length. >> That's what this patch does, going back to the behaviour of >> min_attr_value prior to r267666, with an added comment to stop foolish >> patches in future. >> >> Bootstrapped and regression tested powerpc64le-linux. OK? >> >> PR 88777 >> PR 88614 >> * genattrtab.c (min_fn): Don't translate values. >> (min_attr_value): Return INT_MAX when the value can't be calculated. >> Return minimum among any values that can be calculated. >> (max_attr_value): Adjust. > OK. Given you're likely done for the day I'm going to go ahead and > install it momentarily to make my tester happy again :-)
FWIW, I think this is papering over a deeper issue, but I guess it's OK to install anyway to unbreak builds. Was meaning to have a look today but got sidetracked onto other things, sorry. Thanks, Richard
