On 1/11/19 9:42 AM, Jakub Jelinek wrote:
> Hi!
>
> Since r264052 i386.h includes insn-attr-common.h, which unfortunately isn't
> installed, because all we install is:
> $(PLUGIN_HEADERS) $$(cd $(srcdir); echo *.h *.def)
> and thus plugins compiled against installed tree will not work on x86
> if they need to include anything that includes tm.h.
>
> Below are two possible patches to resolve this.
>
> From the generated headers, we already install
> insn-addr.h insn-codes.h insn-constants.h insn-flags.h insn-modes-inline.h
> insn-modes.h insn-notes.def
> so the missing insn-attr.h insn-attr-common.h looks like an omission to me,
> so the first patch makes sure we install even those two headers on all
> targets.
>
> The other option is install insn-attr-common.h only on x86 where i386.h
> includes it and don't install insn-attr.h at all, which is what the second
> patch does.
>
> Tested on x86_64-linux, ok for trunk (which patch)?
OK. Jeff
