Hi Jakub,
Thanks for review!
On Fri, 21 Dec 2018 14:31:19 +0100
Jakub Jelinek <ja...@redhat.com> wrote:
> On Fri, Dec 21, 2018 at 01:23:03PM +0000, Julian Brown wrote:
> > 2018-xx-yy Nathan Sidwell <nat...@acm.org>
> >
> > PR lto/71959
> > libgomp/
> > * testsuite/libgomp.oacc-c++/pr71959-a.C: New.
> > * testsuite/libgomp.oacc-c++/pr71959.C: New.
>
> Just nits, better use pr71959-aux.cc (*.cc files aren't considered as
> testcases by *.exp:
> set tests [lsort [concat \
> [find $srcdir/$subdir *.C] \
> [find
> $srcdir/$subdir/../libgomp.oacc-c-c++-common *.c]]] ) and just a is
> weird.
Fixed.
> > commit c69dce8ba0ecd7ff620f4f1b8dacc94c61984107
> > Author: Julian Brown <jul...@codesourcery.com>
> > Date: Wed Dec 19 05:01:58 2018 -0800
> >
> > Add testcase from PR71959
> >
> > libgomp/
>
> Please mention
> PR lto/71959
> here in the ChangeLog.
Fixed.
> > * testsuite/libgomp.oacc-c++/pr71959-a.C: New.
> > * testsuite/libgomp.oacc-c++/pr71959.C: New.
>
> > +void apply (int (*fn)(), Iter out) asm
> > ("_ZN5Apply5applyEPFivE4Iter");
>
> Will this work even on targets that use _ or other symbol prefixes?
I'd guess so, else there would be no portable way of using "asm" to
write pre-mangled C++ names. The only existing similar uses I could find
in the testsuite are for the ifunc attribute, not asm, though (e.g.
g++.dg/ext/attr-ifunc-*.C).
Anyway, OpenACC is only useful for a handful of targets at present,
neither of which use special symbol prefixes AFAIK.
> > --- /dev/null
> > +++ b/libgomp/testsuite/libgomp.oacc-c++/pr71959.C
> > @@ -0,0 +1,31 @@
> > +// { dg-additional-sources "pr71959-a.C" }
> > +
> > +// pr lto/71959 ICEd LTO due to mismatch between writing & reading
> > behaviour
>
> Capital PR instead of pr .
Fixed. OK now?
Thanks,
Julian
