On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl <
s...@troutmask.apl.washington.edu> wrote:
> On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote:
> > The attached patch has been tested on x86_64-*-freebsd.
> >
> > OK to commit?
> >
> > 2018-12-20 Steven G. Kargl <ka...@gcc.gnu.org>
> >
> > PR fortran/69121
> > * libgfortran/ieee/ieee_arithmetic.F90: Provide missing functions
> > in interface for IEEE_SCALB.
> >
> > 2018-12-20 Steven G. Kargl <ka...@gcc.gnu.org>
> >
> > PR fortran/69121
> > * gfortran.dg/ieee/ieee_9.f90: New test.
>
> Now, tested on i586-*-freebsd.
>
> --
> Steve
>
Hi, looks ok for trunk.
A few questions popped into my mind while looking into this:
1) Why are none of the _gfortran_ieee_scalb_X_Y functions mentioned in
gfortran.map? I guess they should all be there?
2) Currently all the intrinsics map to the scalbn{,f,l} builtins. However,
when the integer argument is of kind int64 or int128 we should instead use
scalbln{,f,l}. This also applies to other intrinsics that use scalbn under
the hood.
To clarify, fixing these is not a prerequisite for accepting the patch (I
already accepted it), but more like topics for further work.
--
Janne Blomqvist
