On Wed, Dec 19, 2018 at 4:41 PM Andi Kleen <a...@linux.intel.com> wrote: > > > > We can combine the two together, increasing iteration count and > > > decreasing perf count at the same time. What count would you suggest > > > from your experience? > > > > Can we instead for the tests where we want to test profile use/merge > > elide the profiling step and supply the "raw" data in an testsuite alternate > > file instead? > > That would be possible, but a drawback is that we wouldn't have an > "end2end" test anymore that also tests the interaction with perf > and autofdo. Would be good to test these cases too, there were regressions > in this before.
Sure. > But perhaps splitting that into two separate tests is reasonable, > with the majority of tests running with fake data. > > This would have the advantage that gcc developers who don't > have an autofdo setup (e.g. missing tools or running in virtualization > with PMU disabled) would still do most of the regression tests. Yes, I think the pros outweight the cons here. Well, at least if generating such data that works on multiple archs is even possible? Richard. > -Andi
