On Sun, Dec 16, 2018 at 10:43:47AM +0200, Dimitar Dimitrov wrote: > On Fri, Dec 14 2018 2:52:17 EET Segher Boessenkool wrote: > > You need a few tweaks to what you committed. Or just one perhaps: if > > flag_pic is not set, you should not check PIC_OFFSET_TABLE_REGNUM, it is > > meaningless in that case. I'm not sure if you need to check whether the > > register is fixed or not. > The flag_pic flag is already checked by the PIC_OFFSET_TABLE_REGNUM macro. It > will return INVALID_REGNUM if flag_pic is false, so no error will be printed.
No, it is not. On at least six targets the macro is simply defined as a register number. Segher
