Hi Torbjorn,
Just some formatting nitpicking:
On Tue, Nov 27, 2018 at 07:45:59PM +0000, Torbjorn SVENSSON wrote:
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 38e27a50a1e..e61ddc3260b 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -6456,7 +6456,7 @@ Warn if the stack usage of a function might exceed
> @var{byte-size}.
> The computation done to determine the stack usage is conservative.
> Any space allocated via @code{alloca}, variable-length arrays, or related
> constructs is included by the compiler when determining whether or not to
> -issue a warning.
> +issue a warning. @code{asm} statements are ignored when computing stack
> usage.
Two spaces after a full stop. Please try to start sentences with a capital
letter.
> --- a/gcc/function.c
> +++ b/gcc/function.c
> @@ -1822,6 +1822,10 @@ instantiate_virtual_regs_in_insn (rtx_insn *insn)
>
> if (asm_noperands (PATTERN (insn)) >= 0)
> {
> + if (flag_stack_usage_info)
> + {
> + current_function_has_inline_assembler = 1;
> + }
Single statements should not normally get a { block } wrapped around it.
> diff --git a/gcc/function.h b/gcc/function.h
> index 7e59050e8a6..8c3ef49e866 100644
> --- a/gcc/function.h
> +++ b/gcc/function.h
> @@ -208,11 +208,16 @@ struct GTY(()) stack_usage
> /* Nonzero if the amount of stack space allocated dynamically cannot
> be bounded at compile-time. */
> unsigned int has_unbounded_dynamic_stack_size : 1;
> +
> + /* NonZero if body contains asm statement (ignored in stack calculations)
> */
> + unsigned int has_inline_assembler: 1;
"Nonzero", no camelcase. I think it should be "an asm statement", or "some
asm statemement", or similar. The line should end with a full stop and two
spaces, before the */.
> + /* Add info regarding inline assembler (not part of stack calculations) */
Similar here.
Segher
