On Mon, Dec 03, 2018 at 07:18:20PM +0000, Iain Sandoe wrote:
> revised version, on top of the revised patch 1 attached. I’ve taken the
> opportunity to reduce the number of TARGET_MACHO conditionals in rs6000.md
> (handle in rs6000.c instead)
> From 82ac030d49fd2ae78b75a350c5efc59375df42a6 Mon Sep 17 00:00:00 2001
> From: Iain Sandoe <i...@sandoe.co.uk>
> Date: Sat, 1 Dec 2018 16:23:20 +0000
> Subject: [PATCH] [darwin,ppc] Update call expansions to follow the new scheme.
>
> This also makes it a bit more apparent what we can remove when the
> mlongcall optimisation is removed.
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -10285,8 +10285,10 @@
>
> if (DEFAULT_ABI == ABI_AIX || DEFAULT_ABI == ABI_ELFv2)
> rs6000_call_aix (NULL_RTX, operands[0], operands[1], operands[2]);
> - else
> + else if (DEFAULT_ABI == ABI_V4)
> rs6000_call_sysv (NULL_RTX, operands[0], operands[1], operands[2]);
> + else
> + rs6000_call_darwin (NULL_RTX, operands[0], operands[1], operands[2]);
Maybe
else if (DEFAULT_ABI == ABI_DARWIN)
...
else
gcc_unreachable ();
? Similar elsewhere.
And I think I saw a missing space-before-opening-paren somewhere, but I
cannot find it now. Okay for trunk, anyhow.
Segher
