Hi! On Mon, 10 Sep 2018 10:22:17 -0700, Cesar Philippidis <ce...@codesourcery.com> wrote: > On 09/10/2018 08:04 AM, Chung-Lin Tang wrote: > > Index: libgomp/openacc_lib.h > > I don't see a test case for this.
Right. (Better test coverage would be desirable generally.) > I believe that openacc_lib.h is used > by fixed-mode Fortran programs (those that end in a .f). Can you add a > fixed-mode version of lib-16.f90? Not only with fixed-form, but also with free-form Fortran programs. Committed to trunk in r266683: commit d084eb0a61d209ee0d852089ea76a672f519883b Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> Date: Fri Nov 30 20:38:57 2018 +0000 Add libgomp.oacc-fortran/lib-16-2.f90 This is a copy of libgomp.oacc-fortran/lib-16.f90, but does 'include "openacc_lib.h"' instead of 'use openacc'. libgomp/ * testsuite/libgomp.oacc-fortran/lib-16-2.f90: New file. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@266683 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 4 ++++ libgomp/testsuite/libgomp.oacc-fortran/{lib-16.f90 => lib-16-2.f90} | 3 ++- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git libgomp/ChangeLog libgomp/ChangeLog index d3c1bc36c145..a9dcbd808200 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,3 +1,7 @@ +2018-11-30 Thomas Schwinge <tho...@codesourcery.com> + + * testsuite/libgomp.oacc-fortran/lib-16-2.f90: New file. + 2018-10-19 Richard Biener <rguent...@suse.de> PR tree-optimization/88182 diff --git libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 libgomp/testsuite/libgomp.oacc-fortran/lib-16-2.f90 similarity index 94% copy from libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 copy to libgomp/testsuite/libgomp.oacc-fortran/lib-16-2.f90 index 9701b52dd257..fa76f65912fb 100644 --- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 +++ libgomp/testsuite/libgomp.oacc-fortran/lib-16-2.f90 @@ -1,9 +1,10 @@ +! See also "lib-16.f90". ! { dg-do run } ! { dg-skip-if "" { *-*-* } { "*" } { "-DACC_MEM_SHARED=0" } } program main - use openacc implicit none + include "openacc_lib.h" integer, parameter :: N = 256 integer, allocatable :: h(:) diff --git libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 index 9701b52dd257..011f9cf31db4 100644 --- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 +++ libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 @@ -1,3 +1,4 @@ +! See also "lib-16-2.f90". ! { dg-do run } ! { dg-skip-if "" { *-*-* } { "*" } { "-DACC_MEM_SHARED=0" } } Grüße Thomas