On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote:
> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble
> and -mno-popcntd.  The IEEE128 support requires full ISA 2.06 (aka POWER7)
> support, so we really should throw an error when using those options
> together.  Ditto for -mabi=ieeelongdouble and -mno-vsx.  The patch below
> does that.
> 
> Ok for mainline once bootstrap and regtesting are complete and clean?

Okay.  Eventually we shouldn't allow selecting popcntd independently from
-mcpu=, but that day isn't here yet.  So, okay for trunk, and backports
if wanted.  Thanks!


Segher


>       PR target/87496
>       * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow
>       -mabi=ieeelongdouble without both -mpopcntd and -mvsx.
> 
> gcc/testsuite/
>       PR target/87496
>       * gcc.target/powerpc/pr87496.c: New test.

Reply via email to