On Wed, Nov 28, 2018 at 11:54:55PM +1030, Alan Modra wrote: > On Wed, Nov 28, 2018 at 01:12:45PM +0100, Matthias Klose wrote: > > On 27.11.18 00:56, Alan Modra wrote: > > > On Mon, Nov 26, 2018 at 05:16:38PM -0600, Segher Boessenkool wrote: > > >> On Mon, Nov 12, 2018 at 09:56:37PM +1030, Alan Modra wrote: > > >>> Using the macros in config/linux.h rather than duplicating them helps > > >>> stop future bitrot, and repairs existing bitrot (4 choices for libc in > > >>> linux.h, fewer in the rs6000 files not that it matters much). Also > > >>> fixes the fact that __gnu_linux__ was always defined rather than just > > >>> when glibc was the libc of choice. > > >> > > >> Sorry for the slow review. This is okay for trunk. Thanks! > > > > > > Thanks, committed revision 266493. > > > > would that be appropriate to backport to the 7 and 8 branches as well? > > Well, the patch does fix a bug regarding the __gnu_linux__ define, but > no one complained about that as far as I know. So I don't regard it > as important.
It also would need a lot of testing. Yeah, let's not backport this. Segher
