Some assemblers, including the Solaris one, don't support UTF-8 identifiers, which breaks the gdc.test/compilable/ddoc12.d testcase as reported in the PR.
Since we don't want to modify the upstream testcase directly, I've instead modified the gdc.test driver to require ucn support via a dg-require-effective-target directive, based on the file name. Tested on i386-pc-solaris2.11 with gas (which does support them and the test still PASSes) and sparc-sun-solaris2.11 with as (which doesn't, so the test turns out as UNSUPPORTED). Ok for mainline? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2018-11-25 Rainer Orth <r...@cebitec.uni-bielefeld.de> PR d/88039 * gdc.test/gdc-test.exp (dmd2dg): Require ucn support for tests using UCNs in identifiers.
# HG changeset patch # Parent c94c294504322187c207bc70ad6734280adc7043 Require ucn support in gdc.test/compilable/ddoc12.d (PR d/88039) diff --git a/gcc/testsuite/gdc.test/gdc-test.exp b/gcc/testsuite/gdc.test/gdc-test.exp --- a/gcc/testsuite/gdc.test/gdc-test.exp +++ b/gcc/testsuite/gdc.test/gdc-test.exp @@ -276,6 +276,14 @@ proc dmd2dg { base test } { # Since GCC 6-20160131 blank lines are not allowed in the output by default. dg-allow-blank-lines-in-output { 1 } + # Require UCN support for tests with UCN identifiers. + switch $test { + compilable/ddoc12.d { + set out_line "// { dg-require-effective-target ucn }" + puts $fdout $out_line + } + } + # Compilable files are successful if an output is generated. # Fail compilable are successful if an output is not generated. # Runnable must compile, link, and return 0 to be successful by default.