On Mon, 26 Nov 2018 12:20:10 -0800
Mike Stump <mikest...@comcast.net> wrote:

> On Nov 21, 2018, at 2:39 PM, Jozef Lawrynowicz <joze...@mittosystems.com> 
> wrote:
> > 
> > On Wed, 14 Nov 2018 15:41:00 +0000
> > Jozef Lawrynowicz <joze...@mittosystems.com> wrote:
> >   
> >> Patch 3 sets up require-effective-target directives for tests which
> >> require the compilation of large arrays.
> >> Targets which have 16-bit or 20-bit size_t fail to compile tests with large
> >> arrays designed to test 32-bit or 64-bit behaviour. Rather than enumerating
> >> another target to skip, I've replaced the target selector in some tests 
> >> with
> >> a size checking procedure:
> >> - size20plus (new)
> >> - size32plus
> >> size20plus checks to see if a 16-bit structure/array size is supported,
> >> similarly to how the existing size32plus checks to see if a 24-bit
> >> structure/array size is supported,  
> > 
> > Added missing documentation for new check_effective target procs in attached
> > patch.  
> 
> Ok as well.
> 
> I'm assuming that pdp and avr are not negatively affected.

Hi, yes I verified that avr results for the tests I changed are not negatively
affected. The only status change for the tests I modified is FAIL->UNSUPPORTED.

pdp11 has a 16-bit address space, the same msp430 in the small
memory model so there shouldn't be any changes there either.

Thanks for the review, applied.

Jozef

Reply via email to