> On Nov 14, 2018, at 5:19 PM, Jozef Lawrynowicz <joze...@mittosystems.com>
> wrote:
>
> On Wed, 14 Nov 2018 11:30:39 -0500
> Paul Koning <paulkon...@comcast.net> wrote:
>
>>> On Nov 14, 2018, at 10:44 AM, Jozef Lawrynowicz <joze...@mittosystems.com>
>>> wrote:
>>>
>>> Patch 1 tweaks dg directives in tests specifically for msp430. Many of
>>> these are extensions to existing target selectors in dg directives.
>>>
>>> <0001-TESTSUITE-MSP430-Tweak-dg-directives-for-msp430-elf.patch>
>>
>> For pr41779.c, you have
>>
>> +/* { dg-skip-if "int is smaller than float" { msp430-*-* } } */
>>
>> I take it that means: sizeof(int) < sizeof(float). That property also holds
>> for pdp11 and perhaps other targets. Would it make sense to introduce a new
>> effective-target flag for that check instead?
>>
>> paul
>>
>
> Paul,
>
> Yes you are correct the comment implies sizeof(int) < sizeof(float).
>
> I believe this was the only test where this property affected the test
> results, so a new effective-target flag is probably only worth adding if it
> affects at least a couple of tests.
> On the other hand, I suppose there is no harm in adding another
> check-effective-target and it at least means we'll catch failures across more
> targets.
>
> I'd be curious if the line I added the xfail to in c-c++-common/pr57371-2.c
> also fails for pdp11.
>
> The conversion to float might be getting optimized out whenever
> sizeof(int) < sizeof(float).
>
> Thanks,
> Jozef
Yes, that test on pr57371-2.c also fails on pdp11.
paul
