On Fri, Nov 9, 2018 at 6:05 PM Uros Bizjak <ubiz...@gmail.com> wrote: > > On Fri, Nov 9, 2018 at 10:54 AM Wei Xiao <wei.william.x...@gmail.com> wrote: > > > > Hi Uros > > > > Thanks for the remarks! > > I improve the patch as attached to address the issues you mentioned: > > 1. No changes to substs any more. > > 2. Adopt established approach (e.g "<mask_codefor>rcp14<mode><mask_name>") > > to > > handle zero masks. > > > > I'd like to explain our motivation of combining vfixupimm patterns: there > > will > > be a lot of new x86 instructions with both masking and rounding like > > vfixupimm > > in the future but we still want to keep x86 MD as short as possible and > > don't > > want to write 2 patterns for each of these new instructions, which will also > > raise code review cost for maintainer. We want to make sure the new pattern > > paradigm is ok for x86 maintainer through this patch. > > Yes, the patch looks much nicer now. > > +2018-11-09 Wei Xiao <wei3.x...@intel.com> > + *config/i386/sse.md: Combine VFIXUPIMM* patterns > + (<avx512>_fixupimm<mode>_maskz<round_saeonly_expand_name>): Update. > + (<avx512>_fixupimm<mode><sd_maskz_name><round_saeonly_name>): Update. > + (<avx512>_fixupimm<mode>_mask<round_saeonly_name>): Remove. > + (avx512f_sfixupimm<mode>_maskz<round_saeonly_expand_name>): Update. > + (avx512f_sfixupimm<mode><sd_maskz_name><round_saeonly_name>): Update. > + (avx512f_sfixupimm<mode>_mask<round_saeonly_name>): Remove. > > (In future, please add ChangeLog entry to the text of the mail). > > OK for mainline. > > Thanks, > Uros.
Thanks for the review. In future we will pay more attentions to follow the convention. BR, Terry
