Hi,

On Wed, 7 Nov 2018, Martin Liška wrote:

> > Whereever the new function belongs it certainly isn't system.h.  Also 
> > the definition in a header seems excessive.  Sure, it enables inlining 
> > of it, but that seems premature optimization.  It contains a loop, and 
> > inlining anything with loops that aren't very likely to loop just once 
> > or never just blows code for no gain.  Also as the function is leaf 
> > there won't be any second-order effect from inlining.
> 
> Ok, works for me. As you know my main motivation was to provide stronger 
> type declaration that can be used for 'const char *'. So what about 
> providing 2 wrappers and poisoning the implementation?

That seems better.  But still, why declare this in system.h?  It seems 
hash-table.h seems more appropriate.


Ciao,
Michael.

Reply via email to