On Wed, Nov 7, 2018 at 5:12 PM Paul Hua <paul.hua...@gmail.com> wrote: > > Hi, Matthew: > > I committed the patch. Thanks for your review. >
After committed this patch some test failure under with-arch=mips64r2(i only test under -with-arch=loongson3a). 664 FAIL: gcc.target/mips/insn-casesi.c -O0 (test for excess errors) 665 FAIL: gcc.target/mips/insn-casesi.c -O1 (test for excess errors) 666 FAIL: gcc.target/mips/insn-casesi.c -O2 (test for excess errors) 667 FAIL: gcc.target/mips/insn-casesi.c -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors) 668 FAIL: gcc.target/mips/insn-casesi.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) 669 FAIL: gcc.target/mips/insn-casesi.c -O3 -g (test for excess errors) 670 FAIL: gcc.target/mips/insn-casesi.c -Os (test for excess errors) The error message is " /usr/bin/as: unrecognized option '-mno-loongson-mmi' " Those error come from follow options. > mips_option_dependency options "-mips16" "-mno-loongson-mmi" > mips_option_dependency options "-mmicromips" "-mno-loongson-mmi" > mips_option_dependency options "-msoft-float" "-mno-loongson-mmi" > mips_option_dependency options "-mmicromips" "-mno-loongson-ext" We should add those dependency only config with --with-arch=loongson3a/gs464/gs464e/gs246e. I committed the attached patch as obvious. Paul Hua
From 11a0bec83b3a0f2765d35b6aa84263016836f86e Mon Sep 17 00:00:00 2001 From: Chenghua Xu <paul.hua...@gmail.com> Date: Thu, 8 Nov 2018 15:01:35 +0800 Subject: [PATCH] Add mips option dependency only config with loongson target. gcc/testsuite/ * gcc.target/mips/mips.exp (mips-dg-options): Add mips_option_dependency msoft-float vs no-mmi and mips16/micromips vs no-mmi/ext/ext2 only gcc config with Loongson target. --- gcc/testsuite/gcc.target/mips/mips.exp | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/gcc.target/mips/mips.exp b/gcc/testsuite/gcc.target/mips/mips.exp index e70d416d0dd..002cc280e30 100644 --- a/gcc/testsuite/gcc.target/mips/mips.exp +++ b/gcc/testsuite/gcc.target/mips/mips.exp @@ -1054,10 +1054,19 @@ proc mips-dg-options { args } { mips_option_dependency options "-mno-plt" "addressing=unknown" mips_option_dependency options "-mabicalls" "-G0" mips_option_dependency options "-mno-gpopt" "-mexplicit-relocs" - mips_option_dependency options "-mips16" "-mno-loongson-mmi" - mips_option_dependency options "-mmicromips" "-mno-loongson-mmi" - mips_option_dependency options "-msoft-float" "-mno-loongson-mmi" - mips_option_dependency options "-mmicromips" "-mno-loongson-ext" + + if { [check_configured_with "with-arch=loongson3a"] + || [check_configured_with "with-arch=gs464"] + || [check_configured_with "with-arch=gs464e"] + || [check_configured_with "with-arch=gs264e"] } { + mips_option_dependency options "-msoft-float" "-mno-loongson-mmi" + mips_option_dependency options "-mips16" "-mno-loongson-mmi" + mips_option_dependency options "-mips16" "-mno-loongson-ext" + mips_option_dependency options "-mips16" "-mno-loongson-ext2" + mips_option_dependency options "-mmicromips" "-mno-loongson-mmi" + mips_option_dependency options "-mmicromips" "-mno-loongson-ext" + mips_option_dependency options "-mmicromips" "-mno-loongson-ext2" + } # Work out information about the current ABI. set abi_test_option_p [mips_test_option_p options abi] -- 2.18.0