Andreas Krebbel <[email protected]> writes:
> This is caused by changing t-crtstuff-pic from:
> CRTSTUFF_T_CFLAGS_S = $(CRTSTUFF_T_CFLAGS) -fPIC
> to:
> CRTSTUFF_T_CFLAGS_S = $(CRTSTUFF_T_CFLAGS) $(PICFLAG)
>
> With that change the crtbeginS file is built with -fpic instead of -fPIC and
> therefore the
> relocation above fails due to a GOT overflow.
>
> -fPIC compared to -fpic causes a small overhead in the generated code so I'm
> not sure if
> that should be changed in config/picflag.m4. I think I would prefer to go
> back to the old
> t-crtstuff-pic instead.
The -fpic came from libiberty/configure.ac, with no explanation. Since
the PICFLAG setting is supposed to be generically usable, I'd suggest to
remove the -fpic setting in picflag.m4 instead. If you still prefer to
stay with that value, please change s390/t-crtstuff instead of the
shared t-crtstuff-pic, with a comment giving the rationale.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
