On 31/10/2018 22:04, co...@sdf.org wrote: > On Wed, Oct 31, 2018 at 03:23:27PM +0000, Richard Earnshaw (lists) wrote: >> On 31/10/2018 14:10, co...@sdf.org wrote: >>> + >>> +# Currently there is a bug somewhere in GCC's alias analysis >>> +# or scheduling code that is breaking _fpmul_parts in fp-bit.c. >>> +# Disabling function inlining is a workaround for this problem. >>> +HOST_LIBGCC2_CFLAGS += -fno-inline >> >> This needs to be investigated properly (and fixed if it's still a problem). >> >> R. > > After some VCS digging, it turns out you committed this change: > https://github.com/gcc-mirror/gcc/commit/cffb2a26c44c682185b6bb405d48fcbe1fbc0b37 > > NetBSD copied it over from existing GCC files, and it still exists in > GCC trunk, in libgcc/config/arm/t-elf. >
Sorry about that. You don't really expect me to remember every patch I committed 18 years ago! And pedantically, that was a branch merge patch. The original commit (back in the CVS days) was: revision 1.9.2.1 date: 1999/10/25 17:47:02; author: [redacted]; state: Exp; lines: +34 -10 Initial check in of merged arm/thumb backend. However, the age of this makes me suspect that it quite likely is not relevant any more and that we should investigate whether it is safe to remove. We're running some tests here, but can you test the NetBSD port without that as well for another data point? R.
