On 30/10/2018 10:09, Sameera Deshpande wrote: > On Tue, 9 Oct 2018 at 04:08, Eric Botcazou <ebotca...@adacore.com> wrote: >> >>> Other notes need not be changed, as they don't hold renamed register >>> information. >>> >>> Ok for trunk? >> >> No, REG_DEAD & REG_UNUSED note must be recomputed by passes consuming them. >> >>> 2018-10-09 Sameera Deshpande <sameera.deshpa...@linaro.org >>> >>> * gcc/regrename.c (regrename_do_replace): Add condition to alter >>> regname if note has same register marked dead in notes. >> >> No gcc/ prefix in gcc/ChangeLog. >> >> -- >> Eric Botcazou > > Hi Eric, > > Thanks for your comments. > > Please find attached updated patch invoking data flow for updating the > REG_DEAD and REG_UNUSED notes. > > As this change is made in falkor specific file, adding James and > Richard for review. > > Ok for trunk? > > Changelog: > > 2018-10-30 Sameera Deshpande <sameera.deshpa...@linaro.org > > * gcc/config/aarch64/falkor-tag-collision-avoidance.c > (execute_tag_collision_avoidance): Invoke df_note_add_problem to > recompute REG_DEAD and REG_UNUSED notes before analysis. >
'Call df_note_add_problem.' is enough. OK with that change. R. > > bug87330.patch > > diff --git a/gcc/config/aarch64/falkor-tag-collision-avoidance.c > b/gcc/config/aarch64/falkor-tag-collision-avoidance.c > index fb6568f..4ca9d66 100644 > --- a/gcc/config/aarch64/falkor-tag-collision-avoidance.c > +++ b/gcc/config/aarch64/falkor-tag-collision-avoidance.c > @@ -805,6 +805,7 @@ execute_tag_collision_avoidance () > df_set_flags (DF_RD_PRUNE_DEAD_DEFS); > df_chain_add_problem (DF_UD_CHAIN); > df_compute_regs_ever_live (true); > + df_note_add_problem (); > df_analyze (); > df_set_flags (DF_DEFER_INSN_RESCAN); > >
