On 22 October 2018 19:49:35 CEST, Andrew Burgess <andrew.burg...@embecosm.com> 
wrote:
>* Claudiu Zissulescu <claz...@gmail.com> [2018-10-10 11:00:14 +0300]:

>> --- a/gcc/config/arc/arc.c
>> +++ b/gcc/config/arc/arc.c
>> @@ -10803,6 +10803,169 @@ arc_cannot_substitute_mem_equiv_p (rtx)
>>    return true;
>>  }
>>  
>> +/* Checks whether the operands are valid for use in an LDD/STD
>> +   instruction.      Assumes that RT, RT2, and RN are REG.  This is
>> +   guaranteed by the patterns.      Assumes that the address in the base
>> +   register RN is word aligned.      Pattern guarantees that both memory
>> +   accesses use the same base register, the offsets are constants
>> +   within the range, and the gap between the offsets is 4.  If
>preload
>> +   complete then check that registers are legal.  WBACK indicates
>> +   whether address is updated.      */
>
>You've got tabs instead of whitespace inside both this comment block,
>and others within this patch.  It should be period and two whitespace
>at the end of each sentence.

See contrib/check_GNU_style.py

Also:

s/If preload/If reload/

thanks,

Reply via email to