Hi Rainer,
On 10/9/18 3:05 PM, Rainer Orth wrote:
> Hi Bernd,
>
>>> * The merge-all-constants-2.c test doesn't FAIL on Solaris/SPARC with
>>> /bin/as, although it lacks string merging support, too. The assembler
>>> output contains
>>>
>>> .section ".rodata"
>>>
>>> so the pattern currently used to check for .rodata is too
>>> restrictive. There is assembler syntax beyond gas on x86 ;-)
>>>
>>
>> For the test that failed with the quotes around .rodata. I think
>> instead of looking for a end of line immediately after .rodata, it
>> would be sufficient to make sure it does not continue with .str, so
>> could you please try to add something like the following to your patch?
>>
>> Index: gcc/testsuite/gcc.dg/merge-all-constants-2.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/merge-all-constants-2.c (revision 264888)
>> +++ gcc/testsuite/gcc.dg/merge-all-constants-2.c (working copy)
>> @@ -5,4 +5,4 @@
>> const char str2[37] = "0123456789abcdefghijklmnopqrstuvwxyz";
>> const char str3[10] = "0123456789abcdefghijklmnopqrstuvwxyz";
>>
>> -/* { dg-final { scan-assembler-not "\\.rodata\[\n\r\]" } } */
>> +/* { dg-final { scan-assembler-not "\\.rodata\[^.]" } } */
>
> to do this; I've temporarily disabled the string_merging requirement in
> the test and ran it on sparc-sun-solaris2.11:
>
> * With as (no string merging), there's
>
> .section ".rodata"
>
> in the output and I get the expected
>
> FAIL: gcc.dg/merge-all-constants-2.c scan-assembler-not \\.rodata[^.]
>
> * With gas however (string merging supported), the output has the usual
>
> .section .rodata.str1.8,"aMS",@progbits,1
>
> and the test PASSes.
>
which is okay, right?
Bernd.
