On 10/15/18 8:31 AM, Richard Sandiford wrote: > Some tests for COMPLETE_TYPE_P are just protecting against a null > TYPE_SIZE or TYPE_SIZE_UNIT. Rather than replace them with a new > macro, it seemed clearer to write out the underlying test. > > 2018-10-15 Richard Sandiford <richard.sandif...@arm.com> > > gcc/ > * calls.c (initialize_argument_information): Replace COMPLETE_TYPE_P > with checks for null. > * config/aarch64/aarch64.c (aapcs_vfp_sub_candidate): Likewise. > * config/arm/arm.c (aapcs_vfp_sub_candidate): Likewise. > * config/powerpcspe/powerpcspe.c (rs6000_aggregate_candidate): > Likewise. > * config/riscv/riscv.c (riscv_flatten_aggregate_field): Likewise. > * config/rs6000/rs6000.c (rs6000_aggregate_candidate): Likewise. > * expr.c (expand_assignment, safe_from_p): Likewise. > (expand_expr_real_1): Likewise. > * tree-data-ref.c (initialize_data_dependence_relation): Likewise. > * tree-sra.c (maybe_add_sra_candidate): Likewise. > (find_param_candidates): Likewise. > * tree-ssa-alias.c (indirect_ref_may_alias_decl_p): Likewise. > * tree-vrp.c (vrp_prop::check_mem_ref): Likewise. > > gcc/lto/ > * lto-symtab.c (warn_type_compatibility_p): Likewise. This seems largely independent of the larger changes you're trying to make and could stand on its own.
I'm going to assume that you evaluated these instances of COMPLETE_TYPE_P and determined that type completeness isn't really a factor in the affected code. OK if nobody objects by Monday. jeff
