On 10/11/2018 09:20 AM, Paul Koning wrote:
Since the code that uses the doloop_end pattern does not check the operand mode
as given in the pattern, the pattern itself may need to do this, and that was
not documented. This patch adds that information. It also updates the example
to reflect this.
Ok for trunk?
I have no comments on the technical correctness of this patch, but one
nit-picky thing that caught my eye....
Index: doc/md.texi
===================================================================
--- doc/md.texi (revision 265042)
+++ doc/md.texi (working copy)
@@ -7619,7 +7619,23 @@ simplified) from the PDP-11 target:
@smallexample
@group
-(define_insn "doloop_end"
+(define_expand "doloop_end"
+ [(parallel [(set (pc)
+ (if_then_else
+ (ne (match_operand:HI 0 "nonimmediate_operand" "+r,!m")
I wonder if the above code line is too long and might overflow the right
margin. Did you try to generate a PDF and look at it? Just to be safe,
you might try to reformat this example to have less indentation.
Otherwise it looks OK to me.
-Sandra
