On Tue, Oct 2, 2018 at 3:28 PM Peter Bergner <berg...@linux.ibm.com> wrote:
>
> On 10/2/18 4:52 PM, H.J. Lu wrote:
> > I saw the same failures:
> >
> > FAIL: gcc.target/i386/pr49095.c scan-assembler-times \\), % 8
> > FAIL: gcc.target/i386/pr49095.c scan-assembler-times \\), % 8
> >
> > I think the new ones are better, especially in 32-bit case:
>
> Excellent! Does the following test case patch make it so that
> it PASSes again?
>
> Peter
>
>
> Index: gcc/testsuite/gcc.target/i386/pr49095.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/pr49095.c (revision 264793)
> +++ gcc/testsuite/gcc.target/i386/pr49095.c (working copy)
> @@ -73,4 +73,5 @@ G (long)
> /* { dg-final { scan-assembler-not "test\[lq\]" } } */
> /* The {f,h}{char,short,int,long}xor functions aren't optimized into
> a RMW instruction, so need load, modify and store. FIXME eventually. */
> -/* { dg-final { scan-assembler-times "\\), %" 8 } } */
> +/* { dg-final { scan-assembler-times "\\), %" 57 { target { ia32 } } } } */
> +/* { dg-final { scan-assembler-times "\\), %" 45 { target { lp64 } } } } */
^^^^^ This is wrong.
It should be not ia32. Otherwise, it will skip x32.
--
H.J.
