Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

[Martin Liška]

Hi Jeff.

I noticed that your commit r264328 introduced this:

gcc/builtins.c:
...
   579        tree rhs1 = gimple_assign_rhs1 (stmt);
   580        tree_code code = gimple_assign_rhs_code (stmt);
   581        if (code == ADDR_EXPR
   582            && TREE_CODE (TREE_OPERAND (rhs1, 0)) == ARRAY_REF)
   583          rhs1 = rhs1; <---- here
   584        else if (code != POINTER_PLUS_EXPR)
   585          return NULL_TREE;
...

which is reported by LLVM as warning:
gcc/builtins.c:583:2:Semantic Issue: explicitly assigning value of variable of 
type 'tree' (aka 'tree_node *') to itself: -Wself-assign

Can you please fix that?
Thanks,
Martin